Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert #[must_use] in generate_getter #11739

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Insert #[must_use] in generate_getter #11739

merged 1 commit into from
Mar 17, 2022

Conversation

Walther
Copy link
Contributor

@Walther Walther commented Mar 17, 2022

Inserts #[must_use] for the generated getter methods.

From discussion in #11736 and #11738

@lnicola
Copy link
Member

lnicola commented Mar 17, 2022

I can see how some people might prefer not to add #[must_use], but including it is what the standard library does, so it seems reasonable.

bors r+

changelog fix (first contribution) insert #[must_use] in "Generate getter"

@bors
Copy link
Contributor

bors bot commented Mar 17, 2022

Build succeeded:

@bors bors bot merged commit 502e30e into rust-lang:master Mar 17, 2022
@Walther Walther deleted the must_use_for_generate_getter branch March 17, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Walther @lnicola