Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Increase worker thread stack and name them #12466

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Jun 4, 2022

CC #11370

@ivan
Copy link
Contributor

ivan commented Jun 5, 2022

Thanks! I confirmed that this fixes the stack overflow I mentioned in #11370 (comment). I did not have to disable cache priming.

I built rust-analyzer with full lto and tested https://github.com/ludios/ra-chalk-overflow-bug-2 with the default CHALK_SOLVER_ values.

@lnicola
Copy link
Member Author

lnicola commented Jun 5, 2022

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 5, 2022

📌 Commit 0b9cd8a has been approved by lnicola

@bors
Copy link
Collaborator

bors commented Jun 5, 2022

⌛ Testing commit 0b9cd8a with merge 6d3396a...

@ivan
Copy link
Contributor

ivan commented Jun 5, 2022

It looks like a 3MB stack size is also enough to avoid segfaults with https://github.com/ludios/ra-chalk-overflow-bug-2. (Though I now see finding the minimum value doesn't matter because it's virtual memory.)

@bors
Copy link
Collaborator

bors commented Jun 5, 2022

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 6d3396a to master...

@bors bors merged commit 6d3396a into rust-lang:master Jun 5, 2022
@lnicola lnicola deleted the worker-thread-stack branch June 7, 2022 11:46
@ntn-x2
Copy link

ntn-x2 commented Jun 9, 2022

When will this be included in a release? (Having the same issue with our blockchain repo https://github.com/KILTprotocol/kilt-node)

@lnicola
Copy link
Member Author

lnicola commented Jun 9, 2022

It's already included in the latest release, but it doesn't seem to solve the issue completely (see #12484).

@ntn-x2
Copy link

ntn-x2 commented Jun 9, 2022

Can confirm that. I just switched to nightly and I still have the same issue.

@lnicola
Copy link
Member Author

lnicola commented Jun 9, 2022

As a workaround, you could try reducing CHALK_SOLVER_MAX_SIZE to 100 or so, but I haven't tested it. Unfortunately, that doesn't help with #12484.

@Veykril Veykril changed the title Increase worker thread stack and name them internal: Increase worker thread stack and name them Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants