-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: Increase worker thread stack and name them #12466
Conversation
Thanks! I confirmed that this fixes the stack overflow I mentioned in #11370 (comment). I did not have to disable cache priming. I built rust-analyzer with full lto and tested https://github.com/ludios/ra-chalk-overflow-bug-2 with the default |
Thanks! @bors r+ |
📌 Commit 0b9cd8a has been approved by |
It looks like a 3MB stack size is also enough to avoid segfaults with https://github.com/ludios/ra-chalk-overflow-bug-2. (Though I now see finding the minimum value doesn't matter because it's virtual memory.) |
☀️ Test successful - checks-actions |
When will this be included in a release? (Having the same issue with our blockchain repo https://github.com/KILTprotocol/kilt-node) |
It's already included in the latest release, but it doesn't seem to solve the issue completely (see #12484). |
Can confirm that. I just switched to nightly and I still have the same issue. |
As a workaround, you could try reducing |
CC #11370