Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute VSCode variables more generally #14019

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 24, 2023

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 24, 2023
@Veykril
Copy link
Member Author

Veykril commented Jan 24, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 24, 2023

📌 Commit ec94760 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 24, 2023

⌛ Testing commit ec94760 with merge e86bac9...

@bors
Copy link
Collaborator

bors commented Jan 24, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e86bac9 to master...

@bors bors merged commit e86bac9 into rust-lang:master Jan 24, 2023
@Dessix
Copy link

Dessix commented Jan 25, 2023

@Veykril This seems to have caused a regression in the latest build (v0.4.1379). Due to lack of sourcemaps and not having a local build, I've not yet narrowed down the source beyond its final frame:

2023-01-24 19:10:49.661 [error] Activating extension rust-lang.rust-analyzer failed due to an error:
2023-01-24 19:10:49.661 [error] Error: Unexpected function type in substitution
    at Yr (/home/dessix/.vscode-insiders/extensions/rust-lang.rust-analyzer-0.4.1379-linux-x64/out/main.js:41:5460)
    at Yr (/home/dessix/.vscode-insiders/extensions/rust-lang.rust-analyzer-0.4.1379-linux-x64/out/main.js:41:5420)
    at wa.getOrCreateClient (/home/dessix/.vscode-insiders/extensions/rust-lang.rust-analyzer-0.4.1379-linux-x64/out/main.js:96:2623)
    at wa.start (/home/dessix/.vscode-insiders/extensions/rust-lang.rust-analyzer-0.4.1379-linux-x64/out/main.js:96:2959)
    at V_ (/home/dessix/.vscode-insiders/extensions/rust-lang.rust-analyzer-0.4.1379-linux-x64/out/main.js:100:1948)
    at K_ (/home/dessix/.vscode-insiders/extensions/rust-lang.rust-analyzer-0.4.1379-linux-x64/out/main.js:100:763)

I don't appear to have any variable substitutions in my settings.json, am not on NixOS, and have no variable substitutions or similar syntax in my process environment variables.

@lnicola
Copy link
Member

lnicola commented Jan 25, 2023

Reported as #14022.

@Veykril Veykril deleted the ts-bin-og branch January 27, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants