feat: Allow adding extra cargo args when running build scripts

[lnicola]

Closes #14315

Not sure if we want to do it like this or to add an extra config key, though.

[ayush-india]

Waiting for the check to be completed
Thanks a lot mate

[lnicola]

It's waiting for a review, I don't know if this is the best approach.

[ayush-india]

Does not matter to me i am anyway going to complie it from src and use it

[Veykril]

We should add a separate key for that instead and have the check one inherit it like we do with the other configs for these imo

[ayush-india]

@Veykril but for that apporach we need to write all the extra args by hand.

[Veykril]

I'm not sure I understand what you mean, instead of setting rust-analyzer.check.extraArgs you'd be setting rust-analyzer.cargo.extraArgs (or both).

[ayush-india]

@Veykril i cannot find anything named rust-analyzer.cargo.extraArgs.

Sorry if its sounds dumb.

I'm not sure I understand what you mean

The issue i had was when i setted rust-analyzer.check.extraArgs to -r (as you can see in the issue) the problem i had was it made both a debug and release dir. And this pull should fix it (btw i am not a rust expert).

[Veykril]

@Veykril i cannot find anything named rust-analyzer.cargo.extraArgs.

It doesn't exist because thats what I am proposing in adding, the check settings should not affect build script building

[lnicola]

Of course it exists, it's here.

[ayush-india]

@lnicola and @Veykril So it means that i can now use it by
For neovim
local on_attach = require("plugins.configs.lspconfig").on_attach local capabilities = require("plugins.configs.lspconfig").capabilities local lspconfig = require "lspconfig" lspconfig.rust_analyzer.setup { on_attach = on_attach, settings = {["rust-analyzer"] = {cargo = {extraArgs = {"-r"}}}} }
Vscode
rust-analyzer.cargo.extraArgs = ["-r"]

When i clone @lnicola rust-analyzers repo and complie his build-script-extra-args branch

Right, correct me if i am wrong

[lnicola]

Yes.

[ayush-india]

Just a random though: (till when will this feature get added to the "main" rust-analyzer)

[ayush-india]

Idk why i am writing this:

But if i use check.extraArgs it does not work but if i use cargo.extraArgs it does

Thanks mate it fixed my problem (My thinkpad is alive again)

[ayush-india]

But if i use check.extraArgs it does not work but if i use cargo.extraArgs it does

@lnicola Does not work if i restart my editor.

And then i have to recomplie the reelase dir.

And then it works

[lnicola]

Not sure I understand, which parameter are you setting?

[ayush-india]

@lnicola After my indepth research "lol" i find that

When i use your ra it takes around 40s-90s to open ra after a reload (after the first cargo check -r ) but using the stock takes 30s .

But does not fix my problem (makes a debug and rlease dir but your ra does not).

and also takes around 9-11s to get a hover btw does not bother me. I just want only the release dir which your ra provides me.

Again Thanks mate

[ayush-india]

Just a random though: (till when will this feature get added to the "main" rust-analyzer)

@lnicola can you also tell me this

[lnicola]

When i use your ra it takes around 40s-90s to open ra after a reload (after the first cargo check -r ) but using the stock takes 30s .

cargo check -r will be slower (8.45s vs. 8.39s on my system 🙄). Is it also slow on a second load (it shouldn't be)? What if you comment out the setting?

But does not fix my problem (makes a debug and rlease dir but your ra does not).

Yes, that's the point of this branch, to allow you to add that -r there.

and also takes around 9-11s to get a hover btw does not bother me. I just want only the release dir which your ra provides me.

Should only happen on the first hover. There's no reason why my branch would be slower unless you've actually setting -r there, which makes the project load slower the first time. That is, unless you've built RA in the debug/dev profile, but you probably didn't.

Just a random though: (till when will this feature get added to the "main" rust-analyzer)

Whenever Veykril has a chance to look again at this PR. If it's today, it will be even be in the version released tomorrow.

[ayush-india]

Thanks mate you have now answered all my question

Hoping that Veykril will look at this PR.

The rust community is (really really)*9999 helpful. Just hoped that every communtiy was this helpful. And also one more reason to love rust

[Veykril]

@bors r+

[bors]

📌 Commit c3864eb has been approved by Veykril

It is now in the queue for this repository.

[bors]

⌛ Testing commit c3864eb with merge f1e51af...

[bors]

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing f1e51af to master...