Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Initial support for implicit drop inlay hint #16000

Merged
merged 1 commit into from Dec 1, 2023
Merged

feat: Initial support for implicit drop inlay hint #16000

merged 1 commit into from Dec 1, 2023

Conversation

HKalbasi
Copy link
Member

@HKalbasi HKalbasi commented Dec 1, 2023

cc #15785

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2023
@HKalbasi
Copy link
Member Author

HKalbasi commented Dec 1, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 1, 2023

📌 Commit 4d55cac has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 1, 2023

⌛ Testing commit 4d55cac with merge 6e6a0b0...

@bors
Copy link
Collaborator

bors commented Dec 1, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing 6e6a0b0 to master...

@bors bors merged commit 6e6a0b0 into rust-lang:master Dec 1, 2023
10 checks passed
@HKalbasi HKalbasi mentioned this pull request Dec 1, 2023
Open
@bors bors mentioned this pull request Dec 1, 2023
Open
@lnicola lnicola changed the title Initial support for implicit drop inlay hint feat: Initial support for implicit drop inlay hint Dec 3, 2023
@lnicola
Copy link
Member

lnicola commented Dec 4, 2023

image

@rben01
Copy link

rben01 commented Dec 4, 2023 •
edited

Would it be possible for these to go above the statement they precede instead of to the left? Shifting a line right to make room for the drop inlay hint doesn't look so nice. Alternatively, for me, it'd be preferable to have the drop visible when hovering over the return or the }.

@Veykril
Copy link
Member

Veykril commented Dec 4, 2023

Unlikely, this is a limitation by the language server protocol. And VSCode doesnt support ghost text between lines either (only annotations but those dont work that well for this purpose)

@Young-Flash Young-Flash mentioned this pull request Dec 5, 2023
Merged
bors added a commit that referenced this pull request Dec 7, 2023
@bors
Auto merge of #16028 - Young-Flash:fix-issue-16012, r=HKalbasi
bc9c952 
fix: make drop inlay hint more readable

![drop_inlay_hint](https://github.com/rust-lang/rust-analyzer/assets/71162630/bb18707f-3278-435d-a938-ccff4c685586)

follow up #16000, close #16012
@Young-Flash Young-Flash mentioned this pull request Dec 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@HKalbasi @bors @lnicola @rben01 @Veykril @rustbot