feat: Implicit format args support #16027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
implicit-format-args
branch
from
9ae152f
to
8a7958d
Compare
|
Needs a bunch of special casing due to the |
Veykril
force-pushed
the
implicit-format-args
branch
from
813e0ac
to
9b7ec5e
Compare
|
@bors r+ |
Veykril
changed the title
|
☀️ Test successful - checks-actions |
rename-format-args.mp4 |
|
so now we can re-enable clippy lint for this? :) Assuming it will only work by default in the "all params can be included" context. If its a mixed case, that would stay as pedantic. |
|
Yes you should be able to re-enable it now. |
avelanarius
added a commit
to avelanarius/scylla-rust-driver
that referenced
this pull request
Mar 4, 2024
This reverts commit 4964b44. The main reason that uninlined_format_args lint was disabled in Rust Driver's CI/Makefile was that inlined variables in format strings had spotty support in rust-analyzer: rust-analyzer did not support renaming variables inside format strings. Fortunately, rust-analyzer recently gained support for renaming variables in format strings: rust-lang/rust-analyzer#16027, therefore 4964b44 can now be reverted. Moreover, Rust 1.67.1 downgraded uninlined_format_args to pedantic, meaning that it's disabled by default and we don't have to disable it manually. If it's ever promoted back to a enforced rule by default, we'll be ready to deal with it again (with a proper rust-analyzer support) - not addressing it now to avoid merge conflicts with other bigger planned PRs. Closes scylladb#643
avelanarius
added a commit
to avelanarius/scylla-rust-driver
that referenced
this pull request
Mar 4, 2024
This reverts commit 4964b44. The main reason that uninlined_format_args lint was disabled in Rust Driver's CI/Makefile was that inlined variables in format strings had spotty support in rust-analyzer: rust-analyzer did not support renaming variables inside format strings. Fortunately, rust-analyzer recently gained support for renaming variables in format strings: rust-lang/rust-analyzer#16027, therefore 4964b44 can now be reverted. Moreover, Rust 1.67.1 downgraded uninlined_format_args to pedantic, meaning that it's disabled by default and we don't have to disable it manually. If it's ever promoted back to an enforced rule by default, we'll be ready to deal with it again (with a proper rust-analyzer support) - not addressing it now to avoid merge conflicts with other bigger planned PRs. Closes scylladb#643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11260
Fixes #11296
Too lazy to make a gif of this right now (would probably be good to show renaming)