Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix typo in VS Code setting description #17147

Merged
merged 1 commit into from Apr 30, 2024
Merged

docs: Fix typo in VS Code setting description #17147

merged 1 commit into from Apr 30, 2024

Conversation

Wilfred
Copy link
Contributor

@Wilfred Wilfred commented Apr 26, 2024

Replace 'futureg' with 'future'.

@Wilfred Wilfred marked this pull request as ready for review April 26, 2024 23:31
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2024
@Veykril
Copy link
Member

Veykril commented Apr 29, 2024

Needs a cargo test -p rust-analyzer to update the generated config stuff (I feel like we should move that into a prepare step for publishing instead little reason in this being a test honestly)

@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2024
@Veykril
Copy link
Member

Veykril commented Apr 29, 2024

@bors delegate+

@bors
Copy link
Collaborator

bors commented Apr 29, 2024

✌️ @Wilfred, you can now approve this pull request!

If @Veykril told you to "r=me" after making some further change, please make that change, then do @bors r=@Veykril

@Wilfred
Copy link
Contributor Author

Wilfred commented Apr 30, 2024

@bors r=@Veykril

@bors
Copy link
Collaborator

bors commented Apr 30, 2024

📌 Commit b126640 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 30, 2024

⌛ Testing commit b126640 with merge f660835...

@bors
Copy link
Collaborator

bors commented Apr 30, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing f660835 to master...

@bors bors merged commit f660835 into rust-lang:master Apr 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Wilfred @Veykril @bors @rustbot