Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to host platform for cargo metadata #6912

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Default to host platform for cargo metadata #6912

merged 3 commits into from
Dec 17, 2020

Conversation

jonhoo
Copy link
Contributor

@jonhoo jonhoo commented Dec 17, 2020

This modifies the logic for calling cargo metadata so that it will use
the host platform if no explicit target platform is given. This is
needed since cargo metadata defaults to outputting information for all
targets.

Fixes #6908.

Default to host platform for cargo metadata
9802c0c 
This modifies the logic for calling cargo metadata so that it will use
the host platform if no explicit target platform is given. This is
needed since cargo metadata defaults to outputting information for _all_
targets.

Fixes rust-lang#6908.
@matklad
Copy link
Member

matklad commented Dec 17, 2020 •
edited
Loading

Makes sense!

In generally, cargo metadata is fundamentally lossy (what we actually want to get our hands on is the internal unit-graph in cargo), but this should help us to be less incorrect.

r=me with prefix stripping simplified!

bors d+

@bors
Copy link
Contributor

bors bot commented Dec 17, 2020

✌️ jonhoo can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

jonhoo and others added 2 commits December 17, 2020 13:18
@jonhoo @matklad
Update crates/project_model/src/cargo_workspace.rs
71478e0 
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Fun times with rustfmt
faed47b
@jonhoo
Copy link
Contributor Author

jonhoo commented Dec 17, 2020

🎉

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 17, 2020

Build succeeded:

@bors bors bot merged commit b55cb89 into rust-lang:master Dec 17, 2020
@jonhoo jonhoo deleted the metadata-for-target branch December 17, 2020 18:42
@jonhoo jonhoo mentioned this pull request Dec 17, 2020
Closed
@jonhoo jonhoo mentioned this pull request Apr 5, 2021
Closed
This was referenced Apr 27, 2021
Closed
Open
@amzn-aeline amzn-aeline mentioned this pull request Sep 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only use metadata for current target
2 participants
@jonhoo @matklad