Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitfields in unions #1066

Merged
merged 2 commits into from
Oct 10, 2017
Merged

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Oct 9, 2017

Fixes #744

I think it is WIP for the moment as I didn't run tests locally.

@highfive
Copy link

highfive commented Oct 9, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think we can go ahead and land this now :)

@fitzgen
Copy link
Member

fitzgen commented Oct 10, 2017

@bors-servo r+

@bors-servo
Copy link

📌 Commit c187b9f has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit c187b9f with merge 5dbdadc...

bors-servo pushed a commit that referenced this pull request Oct 10, 2017
Bitfields in unions

Fixes #744

I think it is WIP for the moment as I didn't run tests locally.
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 5dbdadc to master...

@bors-servo bors-servo merged commit c187b9f into rust-lang:master Oct 10, 2017
@pepyakin pepyakin deleted the bitfields-in-unions branch October 10, 2017 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants