Bump quote to 0.5 #1303
Bump quote to 0.5 #1303
Conversation
| #![allow(dead_code, non_snake_case, non_camel_case_types, non_upper_case_globals)] | ||
|
|
||
|
|
||
| pub const g_107: ::std::os::raw::c_ulonglong = 18446744073709551615; | ||
| pub const g_107: ::std::os::raw::c_ulonglong = -1; |
There was a problem hiding this comment.
This is because proc-macro2 casts ints as i64 if they aren't suffixed
There was a problem hiding this comment.
This will be fixed after rust-lang/rust#49597 has landed.
There was a problem hiding this comment.
Does that mean another proc-macro2 breaking change ?
There was a problem hiding this comment.
Also this doesn't work for u32 soooo....
This reverts commit eb415c7.
|
Ok this is ready now I think :) |
| /// I'm in an inline namespace, and as such I shouldn't get generated inside | ||
| /// a rust module, except when the relevant option is specified. Also, this | ||
| /// comment shouldn't be misaligned. | ||
| #[doc = " I\'m in an inline namespace, and as such I shouldn\'t get generated inside\n a rust module, except when the relevant option is specified. Also, this\n comment shouldn\'t be misaligned."] |
| @@ -111,7 +96,7 @@ pub mod root { | |||
| concat!("Alignment of ", stringify!(InInlineNS)) | |||
| ); | |||
| } | |||
|
|
|||
| #[doc = ""] | |||
There was a problem hiding this comment.
This should check whether the comment is empty.
src/ir/comment.rs
Outdated
| @@ -54,7 +54,7 @@ fn preprocess_single_lines(comment: &str, indent: usize) -> String { | |||
| let indent = if is_first { "" } else { &*indent }; | |||
| is_first = false; | |||
| let maybe_space = if l.is_empty() { "" } else { " " }; | |||
| format!("{}///{}{}", indent, maybe_space, l) | |||
| format!("{}{}{}", indent, maybe_space, l) | |||
There was a problem hiding this comment.
If we end up going for #[doc] stuff, all the maybe_space stuff can go away, but I don't see how multiline stuff works now, it seems to mangle the documentation, which I think it's not acceptable.
|
@bors-servo r+ |
|
📌 Commit 3258c5a has been approved by |
|
☀️ Test successful - status-travis |
No description provided.