Remove support for clang below version 3.9 #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
emilio
approved these changes
Jul 20, 2020
|
Can you rebase given your PR hit the mem::replace issue? |
It is not clear what version of libclang these supported. Refer to rust-lang#1321, rust-lang#1304, rust-lang#916, rust-lang#915.
kulp
force-pushed
the
deprecate-clang-3_8
branch
from
c30b753
to
c6d9d54
Compare
Done ! |
|
Thanks! |
kulp
added a commit
to kulp/rust-bindgen
that referenced
this pull request
Feb 2, 2022
This could have been enabled in rust-lang#1830, but it was missed.
kulp
added a commit
to kulp/rust-bindgen
that referenced
this pull request
Feb 2, 2022
This could have been enabled in rust-lang#1830, but it was missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
bindgenstill supports forlibclangversion 3.8, and even has vestigial support for older versions. This support has a cost, including the cost of continuous integration testing and extra code paths.LLVM 3.9.0 was released on 02 Sep 2016. The most recent release of LLVM is 10.0.0 (24 Mar 2020).
The current PR implements the first two chunks of #1807 (comment), thereby removing explicit support for
libclangbefore 3.9.