Demonstrate dropping support for libclang < 5.0 #1807
Conversation
|
|
There was a problem hiding this comment.
I'm generally ok with this. https://bugzilla.mozilla.org/show_bug.cgi?id=1579189 updated Firefox's min clang version to 5.0, and this removes some gross hacks.
I do wonder if any other users of bindgen are using such an old libclang...
kulp
force-pushed
the
strip-old-clang
branch
3 times, most recently
from
69a9355
to
fbca047
Compare
|
I reorganized the commits so that support for older clang versions is removed in order, so that we could pick the best place to stop if we did not want to jump to clang 5.0 immediately.
|
|
☔ The latest upstream changes (presumably a492a9e) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably 3e2566d) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment was marked as resolved.
This comment was marked as resolved.
|
☔ The latest upstream changes (presumably 802561e) made this pull request unmergeable. Please resolve the merge conflicts. |
kulp
force-pushed
the
strip-old-clang
branch
from
5fa81fc
to
a0af291
Compare
kulp
force-pushed
the
strip-old-clang
branch
from
a0af291
to
4e39c0c
Compare
|
☔ The latest upstream changes (presumably 4f714ab) made this pull request unmergeable. Please resolve the merge conflicts. |
kulp
force-pushed
the
strip-old-clang
branch
from
4e39c0c
to
2ada480
Compare
|
☔ The latest upstream changes (presumably fde75f6) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably b3e6a98) made this pull request unmergeable. Please resolve the merge conflicts. |
It is not clear why this interface was fallible previously anyway.
kulp
force-pushed
the
strip-old-clang
branch
from
62cf356
to
3cff640
Compare
In #1006 (comment) the idea was raised of possibly removing support for old libclang versions. The current draft PR exists mainly to help evaluate the impact of such an idea. If this idea is not worth pursuing now, the current PR can be closed, but perhaps at least a policy could be determined as to how long old libclang versions should be supported.
For reference:
The impact overall in
bindgenseems quite smallno longer seems small in terms of code size. However, the reduction in bug surface area might still make the change worthwhile, at least in stages. Presumably old issues such as #1006 could be closed.