-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IsOpaque
for CompInfo
#823
Implement IsOpaque
for CompInfo
#823
Conversation
Why is Also, it seems those |
I had to change our defaults from We can still |
370ebee
to
e425971
Compare
Ok, it turns out that the |
Well, stylo isn't updating at least until #826 is fixed I think, but sure, will review this now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(And of course forgot about it). LGTM
src/ir/comp.rs
Outdated
.opaque() | ||
.can_derive_default(ctx, ()); | ||
return layout.map_or(true, |l| l.opaque().can_derive_default(ctx, ())); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Spurious newline.
This allows us to properly detect structs that should be treated as opaque due to their non-type template paramaters, which in turn lets us correctly codegen template aliases to such things. Fixes rust-lang#820
e425971
to
20253fc
Compare
@bors-servo r=emilio |
📌 Commit 20253fc has been approved by |
☀️ Test successful - status-travis |
This allows us to properly detect structs that should be treated as opaque due to their non-type template paramaters, which in turn lets us correctly codegen template aliases to such things.
Fixes #820
r? @emilio