Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status of rustc_tools_util? #9553

Closed
RalfJung opened this issue Sep 29, 2022 · 6 comments · Fixed by #9569
Closed

Status of rustc_tools_util? #9553

RalfJung opened this issue Sep 29, 2022 · 6 comments · Fixed by #9569
Assignees
@matthiaskrgr

Comments

@RalfJung
Copy link
Member

RalfJung commented Sep 29, 2022 •
edited

vergen is causing some licensing pain in Miri, so I checked what clippy does to determine the git commit for version information. Looks like clippy has an in-tree crate rustc_tools_util for that. An old version of that crate exists on crates.io but clippy uses a path dependency of a more up-to-date version of that crate.

Would it make sense for clippy and Miri to share that crate? clippy should then probably fetch the dependency from crates.io rather than using a path dependency, so that the dependency is actually shared in the rustc workspace.
This was referenced Sep 29, 2022
Closed
Merged
bors added a commit to rust-lang/miri that referenced this issue Sep 29, 2022
@bors
Auto merge of #2576 - RalfJung:no-more-vergen, r=RalfJung
1e0a16b 
use rustc_tools_util instead of vergen

This avoids some 0BSD-licensed dependencies (which might or might not be a license we can use), and also just generally removes tons of dependencies and shares some code with clippy. Well, kind-of-shares -- clippy uses a path dependency (rust-lang/rust-clippy#9553) so rustc will still build this twice in the rustc repo.
@matthiaskrgr
Copy link
Member

I could do another clippy repo -> cratess.io sync (aka release) and we could switch clippy to also use the crates-io version while keeping the source in tree, I guess?

@RalfJung
Copy link
Member Author

Yeah I think that would be good. :)

@matthiaskrgr matthiaskrgr self-assigned this Sep 29, 2022
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this issue Sep 30, 2022
@matthiaskrgr
rustc_tool_utils bump version in anticipation of a new release
ef6adc2 
cc rust-lang#9553
@matthiaskrgr matthiaskrgr mentioned this issue Sep 30, 2022
Closed
bors added a commit that referenced this issue Oct 1, 2022
@bors
Auto merge of #9561 - matthiaskrgr:tools_util_bump, r=flip1995
58d9f1e 
rustc_tools_util: bump version in anticipation of a new release

cc #9553

After this is merged, I will publish the 0.2.1 version to crates.io, and make another PR that switches clippy to use the dependency from crates.io.
The source can still be kept in the clippy repo though imo.

This will allow miri and clippy to "share" the crate in the rustc repo once they both depend on it.
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this issue Oct 1, 2022
@matthiaskrgr
rustc_tool_utils bump version in anticipation of a new release
cf44aec 
cc rust-lang#9553
bors added a commit that referenced this issue Oct 1, 2022
@bors
Auto merge of #9561 - matthiaskrgr:tools_util_bump, r=flip1995
2311cee 
rustc_tools_util: bump version in anticipation of a new release

cc #9553

After this is merged, I will publish the 0.2.1 version to crates.io, and make another PR that switches clippy to use the dependency from crates.io.
The source can still be kept in the clippy repo though imo.

This will allow miri and clippy to "share" the crate in the rustc repo once they both depend on it.

changelog: release `rustc_tools_util` on `Crates.io`.
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this issue Oct 1, 2022
@matthiaskrgr
rustc_tool_utils bump version in anticipation of a new release
826690f 
cc rust-lang#9553
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this issue Oct 1, 2022
@matthiaskrgr
rustc_tool_utils bump version in anticipation of a new release
418b30b 
cc rust-lang#9553
@matthiaskrgr matthiaskrgr mentioned this issue Oct 1, 2022
Merged
bors added a commit that referenced this issue Oct 1, 2022
@bors
Auto merge of #9568 - matthiaskrgr:tools_util_bump, r=flip1995
8030ee9 
rustc_tool_utils: bump version in anticipation of a new release

cc #9553

After this is merged, I will publish the 0.2.1 version to crates.io, and make another PR that switches clippy to use the dependency from crates.io.
The source can still be kept in the clippy repo though imo.

This will allow miri and clippy to "share" the crate in the rustc repo once they both depend on it.

reopen of #9561

changelog: release `rustc_tools_util` on `Crates.io`.
@matthiaskrgr
Copy link
Member

rustc_tools_util 0.2.1 is now on crates-io 🎉

@matthiaskrgr matthiaskrgr mentioned this issue Oct 1, 2022
Merged
bors added a commit that referenced this issue Oct 1, 2022
@bors
Auto merge of #9569 - matthiaskrgr:rtu_from_cratesio, r=xFrednet
7dc8d10 
use rustc_tools_util dependency from crates.io instead of this repo.

Fixes #9553

changelog: none
bors added a commit that referenced this issue Oct 1, 2022
@bors
Auto merge of #9569 - matthiaskrgr:rtu_from_cratesio, r=xFrednet
9b6b452 
use rustc_tools_util dependency from crates.io instead of this repo.

Fixes #9553

changelog: none
@bors bors closed this as completed in ce609c6 Oct 1, 2022
@RalfJung RalfJung mentioned this issue Oct 2, 2022
Merged
bors added a commit to rust-lang/miri that referenced this issue Oct 2, 2022
@bors
Auto merge of #2578 - RalfJung:rustc_tools_util, r=RalfJung
30ab2d1 
bump rustc_tools_util

Cc rust-lang/rust-clippy#9553
@RalfJung
Copy link
Member Author

RalfJung commented Oct 2, 2022

Thanks. :) it is being bumped in Miri as we speak.

@matthiaskrgr
Copy link
Member

we might still need a clippy sync to get rid of the path dep in the rustc repo though

@RalfJung
Copy link
Member Author

RalfJung commented Oct 2, 2022

Yeah and a Miri sync needs to happen for Miri to even start using it. Short-term there might be some duplication but in the near future, after they both got synced, we'll have this code shared. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthiaskrgr matthiaskrgr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use rustc_tools_util dependency from crates.io instead of this repo. matthiaskrgr/rust-clippy
2 participants
@RalfJung @matthiaskrgr