trim paths in box_default
#10153
Merged
trim paths in box_default
#10153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
How does this handle cases where the path (or part of it) is actually needed? |
|
The macro just reduces paths that have active imports, so the shortened paths are guaranteed to lead to the same item as the fully qualified paths. It's also used in the compiler, btw. |
bors
added a commit
that referenced
this pull request
Jan 6, 2023
trim paths in `default_trait_access`/`clone_on_copy` suggestions This should help making the suggestions more palatable. Similar to #10153. --- changelog: trim paths in [`default_trait_access`]/[`clone_on_copy`] suggestions
|
Sounds good. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might help with #10089, though I have not tested that yet. In any event, it keeps the suggestion short and to the point.
changelog: Trim paths in [
box_default] suggestion