Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim paths in default_trait_access/clone_on_copy suggestions #10160

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Jan 4, 2023

This should help making the suggestions more palatable. Similar to #10153.


changelog: trim paths in [default_trait_access]/[clone_on_copy] suggestions

@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 4, 2023
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

Thanks for this

@dswij
Copy link
Member

dswij commented Jan 6, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 6, 2023

📌 Commit 05ba519 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 6, 2023

⌛ Testing commit 05ba519 with merge 3f48ed5...

@bors
Copy link
Collaborator

bors commented Jan 6, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 3f48ed5 to master...

@bors bors merged commit 3f48ed5 into rust-lang:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants