Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests_outside_test_module lint #10543

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Add tests_outside_test_module lint #10543

merged 3 commits into from
Apr 4, 2023

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented Mar 24, 2023

Adds tests_outside_test_module from #10506. This PR doesn't close the issue, just resolves task 1.

changelog: [tests_outside_test_module]: The lint has been added

@rustbot
Copy link
Collaborator

rustbot commented Mar 24, 2023

r? @flip1995

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 24, 2023
@blyxyas blyxyas mentioned this pull request Mar 27, 2023
Closed
3 tasks
@bors
Copy link
Collaborator

bors commented Mar 30, 2023

☔ The latest upstream changes (presumably #9102) made this pull request unmergeable. Please resolve the merge conflicts.

@blyxyas blyxyas mentioned this pull request Mar 31, 2023
Merged
@bors
Copy link
Collaborator

bors commented Apr 1, 2023

☔ The latest upstream changes (presumably #10534) made this pull request unmergeable. Please resolve the merge conflicts.

flip1995
flip1995 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some major nitpicking.

clippy_lints/src/tests_outside_test_module.rs Outdated Show resolved Hide resolved
clippy_lints/src/tests_outside_test_module.rs Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

flip1995 commented Apr 4, 2023

Thanks for addressing everything so quickly!

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 4, 2023

📌 Commit b2f9191 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 4, 2023

⌛ Testing commit b2f9191 with merge 5d149c5...

@blyxyas
Copy link
Member Author

blyxyas commented Apr 4, 2023

They called me Speedy McQuick in high school

@bors
Copy link
Collaborator

bors commented Apr 4, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 5d149c5 to master...

@bors bors merged commit 5d149c5 into rust-lang:master Apr 4, 2023
bors added a commit that referenced this pull request Apr 21, 2023
@bors
Auto merge of #10578 - blyxyas:items_after_test_module, r=dswij
138f692 
Add `items_after_test_module` lint

Resolves task *3* of #10506, alongside *1* resolved at #10543 in an effort to help standarize a little bit more testing modules.

---

changelog:[`items_after_test_module`]: Added the lint.
bors added a commit that referenced this pull request Apr 22, 2023
@bors
Auto merge of #10578 - blyxyas:items_after_test_module, r=dswij
0884d16 
Add `items_after_test_module` lint

Resolves task *3* of #10506, alongside *1* resolved at #10543 in an effort to help standarize a little bit more testing modules.

---

changelog:[`items_after_test_module`]: Added the lint.
bors added a commit that referenced this pull request Apr 23, 2023
@bors
Auto merge of #10578 - blyxyas:items_after_test_module, r=dswij
a3ed905 
Add `items_after_test_module` lint

Resolves task *3* of #10506, alongside *1* resolved at #10543 in an effort to help standarize a little bit more testing modules.

---

changelog:[`items_after_test_module`]: Added the lint.
@blyxyas blyxyas deleted the tests_outside_test_module branch October 5, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blyxyas @rustbot @bors @flip1995