Add configuration for semicolon_block lints

[Centri3]

Does exactly what it says on the tin, suggests moving a block's final semicolon inside if it's multiline and outside if it's singleline.

I don't really like how this is implemented so I'm not too sure if this is ready yet. Alas, it might be ok.

---

fixes #10654

changelog: Enhancement: [semicolon_inside_block]: Added semicolon-inside-block-ignore-singleline as a new config value.
#10656
changelog: Enhancement: [semicolon_outside_block]: Added semicolon-outside-block-ignore-multiline as a new config value.
#10656

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[Centri3]

I think I will rewrite this later. I created this while half-asleep and so it's a bit more of a hacky solution than I'd like 🙂 It works currently but could be cleaner.

[xFrednet]

Hey! Code written in the half-asleep state can be quite genius. At least there are quite a few PRs I created in that state which weren't too bad ^^. I planned to do a review of this on Wednesday, is that fine with you, or should I wait on the planned rewrite :)

[Centri3]

Hey! Code written in the half-asleep state can be quite genius. At least there are quite a few PRs I created in that state which weren't too bad ^^. I planned to do a review of this on Wednesday, is that fine with you, or should I wait on the planned rewrite :)

Wednesday sounds good, I think I can get it done by then. Thanks!

e: Disregard this 😅 I think I may just refactor instead.

[xFrednet]

The implementation overall looks good to me. I left two comments, where I would like your feedback on.

Also, because I didn't say that earlier: Welcome to Clippy 👋 📎

[xFrednet]

This generally looks good to me, some nits and a few questions to make sure, that I understand everything correctly :)

[xFrednet]

Looks good to me, thank you for the update and addressing all my review comments. I hope you had fun working on Clippy :D

@bors r+

[bors]

📌 Commit e3ee10d has been approved by xFrednet

It is now in the queue for this repository.

[bors]

⌛ Testing commit e3ee10d with merge 22e2bd8...

[bors]

💔 Test failed - checks-action_test

[Centri3]

whoops, forgot to run cargo collect-metadata 😅 I think you'll need to reapprove this, @xFrednet

[xFrednet]

Yes, that's what the CI is for. Thank you!

@bors r+

[bors]

📌 Commit 8c8cf40 has been approved by xFrednet

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8c8cf40 with merge 990bbdc...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 990bbdc to master...