Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[match_same_arms]: don't lint if non_exhaustive_omitted_patterns #10946

Merged
merged 1 commit into from Jun 15, 2023
Merged

[match_same_arms]: don't lint if non_exhaustive_omitted_patterns #10946

merged 1 commit into from Jun 15, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jun 13, 2023

Fixes #10327

changelog: [match_same_arms]: Don't lint if non_exhaustive_omitted_patterns is warn or deny

@rustbot
Copy link
Collaborator

rustbot commented Jun 13, 2023

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 13, 2023
@xFrednet
Copy link
Member

Hey @blyxyas, do you want to take a look at this PR? :)

@blyxyas
Copy link
Member

blyxyas commented Jun 13, 2023

Yeehaw 🤠 (Yes)

@xFrednet
Copy link
Member

I love how much fun you're having with the comments =^.^=

blyxyas
blyxyas requested changes Jun 13, 2023
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, everything's good, thanks!
(What a hard PR to review)

tests/ui/match_same_arms_non_exhaustive.rs Outdated Show resolved Hide resolved
@Centri3 Centri3 force-pushed the match_same_arms branch 2 times, most recently from ce51b5c to 8cd122d Compare June 13, 2023 22:49
xFrednet
xFrednet reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but I think we should make the lint suppression more fine-grained :)

clippy_lints/src/matches/match_same_arms.rs Outdated Show resolved Hide resolved
clippy_lints/src/matches/match_same_arms.rs Show resolved Hide resolved
@xFrednet
Copy link
Member

LGTM, thank you for this nice update :D

@bors r=blyxyas,xFrednet

@bors
Copy link
Collaborator

bors commented Jun 15, 2023

📌 Commit 27a701a has been approved by blyxyas,xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 15, 2023

⌛ Testing commit 27a701a with merge cda13a8...

@bors
Copy link
Collaborator

bors commented Jun 15, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas,xFrednet
Pushing cda13a8 to master...

@bors bors merged commit cda13a8 into rust-lang:master Jun 15, 2023
5 checks passed
@Centri3 Centri3 deleted the match_same_arms branch June 15, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarcho Jarcho Jarcho left review comments

@blyxyas blyxyas blyxyas requested changes

@xFrednet xFrednet xFrednet approved these changes

Assignees

@xFrednet xFrednet

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive in match_same_arms + non_exhaustive_omitted_patterns
6 participants
@Centri3 @rustbot @xFrednet @blyxyas @bors @Jarcho