single_match: fix checking of explicitly matched enums
#11441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Jarcho
force-pushed
the
issue_11365
branch
2 times, most recently
from
ce1b80f
to
f475b85
Compare
|
☔ The latest upstream changes (presumably #11563) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? clippy |
|
☔ The latest upstream changes (presumably #12198) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I won't be back until Wednesday. If anyone have the capacity, feel free to review this :) r? clippy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11365
This approach has false-negatives, but fixing them will require a significant amount of additional state tracking. The comment in
add_and_patshas the explanation.changelog:
single_match: correct checking if the match explicitly matches all of an enum's variants.