Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultUnionRepresentation: explain why we only warn about unions with at least 2 non-ZST fields #11448

Merged
merged 1 commit into from Sep 2, 2023

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 2, 2023

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2023

r? @blyxyas

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 2, 2023
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Sep 2, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 2, 2023

📌 Commit 79e31cb has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 2, 2023

⌛ Testing commit 79e31cb with merge 7cf96da...

@bors
Copy link
Collaborator

bors commented Sep 2, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 7cf96da to master...

@bors bors merged commit 7cf96da into rust-lang:master Sep 2, 2023
5 checks passed
@RalfJung RalfJung deleted the DefaultUnionRepresentation branch September 2, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants