Fix mutaby used async function argument in closure for needless_pass_by_ref_mut
#11492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
changed the title
needless_pass_by_ref_mutneedless_pass_by_ref_mut
GuillaumeGomez
force-pushed
the
async-fn-returned-closure
branch
from
a29495f
to
cadc95e
Compare
GuillaumeGomez
force-pushed
the
async-fn-returned-closure
branch
from
cadc95e
to
e3267b1
Compare
Centri3
reviewed
Sep 18, 2023
…sync functions right besides other closures handling. Add doc comment explaining what `MutablyUsedVariablesCtxt::prev_move_to_closure` is about.
|
Applied your suggestions @Centri3. |
|
@bors r+ Thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Still seeing this on 2023-09-21, I guess the nightly build happened before the merge? I'm always unclear on what the exact timing is there. |
|
Sync hasn't happened yet, last one was rust-lang/rust#115790. It's biweekly so it'll be a few days until it's in nightly. |
wbinnssmith
added a commit
to vercel/turbo
that referenced
this pull request
Oct 6, 2023
This: - Updates rust-toolchain to nightly-2023-10-06 - Removes allowing clippy rules for needless_pass_by_ref_mut and non_canonical_partial_ord_impl as the linked issues appear to have been resolved in [0] and [1] respectively - Fixes apparently legitimate issues now reported by clippy Test Plan: CI [0] rust-lang/rust-clippy#11492 [1] rust-lang/rust-clippy#11188
wbinnssmith
added a commit
to vercel/turbo
that referenced
this pull request
Oct 10, 2023
This: - Updates rust-toolchain to nightly-2023-10-06 - Removes allowing clippy rules for needless_pass_by_ref_mut and non_canonical_partial_ord_impl as the linked issues appear to have been resolved in [0] and [1] respectively - Fixes apparently legitimate issues now reported by clippy Test Plan: CI [0] rust-lang/rust-clippy#11492 [1] rust-lang/rust-clippy#11188 Closes WEB-1732
Zertsov
pushed a commit
to vercel/turbo
that referenced
this pull request
Oct 11, 2023
This: - Updates rust-toolchain to nightly-2023-10-06 - Removes allowing clippy rules for needless_pass_by_ref_mut and non_canonical_partial_ord_impl as the linked issues appear to have been resolved in [0] and [1] respectively - Fixes apparently legitimate issues now reported by clippy Test Plan: CI [0] rust-lang/rust-clippy#11492 [1] rust-lang/rust-clippy#11188 Closes WEB-1732
|
Hi, this issue exists on the beta build currently. Can we get this fix backported? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11380.
The problem was that it needed to go through closures as well in async functions to correctly find the mutable usage of async function arguments.
changelog: Correctly handle mutable usage of async function arguments in closures.
r? @Centri3