-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rust-toolchain to nightly-2023-10-06 #6128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This: - Updates rust-toolchain to nightly-2023-10-06 - Removes allowing clippy rules for needless_pass_by_ref_mut and non_canonical_partial_ord_impl as the linked issues appear to have been resolved in [0] and [1] respectively - Fixes apparently legitimate issues now reported by clippy Test Plan: CI [0] rust-lang/rust-clippy#11492 [1] rust-lang/rust-clippy#11188
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 11 Ignored Deployments
|
Logs
See job summary for details |
Linux Benchmark for d1c1a1e
Click to view full benchmark
|
|
wbinnssmith
added a commit
that referenced
this pull request
Oct 6, 2023
Along with #6128, this should address most the reported clippy issues.
wbinnssmith
requested review from
kwonoj,
sokra,
jridgewell and
ForsakenHarmony
October 6, 2023 22:23
jridgewell
approved these changes
Oct 7, 2023
sokra
approved these changes
Oct 7, 2023
ForsakenHarmony
approved these changes
Oct 7, 2023
wbinnssmith
added a commit
that referenced
this pull request
Oct 10, 2023
Zertsov
pushed a commit
that referenced
this pull request
Oct 11, 2023
This: - Updates rust-toolchain to nightly-2023-10-06 - Removes allowing clippy rules for needless_pass_by_ref_mut and non_canonical_partial_ord_impl as the linked issues appear to have been resolved in [0] and [1] respectively - Fixes apparently legitimate issues now reported by clippy Test Plan: CI [0] rust-lang/rust-clippy#11492 [1] rust-lang/rust-clippy#11188 Closes WEB-1732
Zertsov
pushed a commit
that referenced
this pull request
Oct 11, 2023
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Oct 13, 2023
### What? see vercel/turborepo#6160 ### Turbopack Changes * vercel/turborepo#6116 * vercel/turborepo#6140 * vercel/turborepo#6118 * vercel/turborepo#6128 * vercel/turborepo#6129 * vercel/turborepo#6160 Closes WEB-1772 Co-authored-by: Justin Ridgewell <112982+jridgewell@users.noreply.github.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
This: - Updates rust-toolchain to nightly-2023-10-06 - Removes allowing clippy rules for needless_pass_by_ref_mut and non_canonical_partial_ord_impl as the linked issues appear to have been resolved in [0] and [1] respectively - Fixes apparently legitimate issues now reported by clippy Test Plan: CI [0] rust-lang/rust-clippy#11492 [1] rust-lang/rust-clippy#11188 Closes WEB-1732
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
This: - Updates rust-toolchain to nightly-2023-10-06 - Removes allowing clippy rules for needless_pass_by_ref_mut and non_canonical_partial_ord_impl as the linked issues appear to have been resolved in [0] and [1] respectively - Fixes apparently legitimate issues now reported by clippy Test Plan: CI [0] rust-lang/rust-clippy#11492 [1] rust-lang/rust-clippy#11188 Closes WEB-1732
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
This: - Updates rust-toolchain to nightly-2023-10-06 - Removes allowing clippy rules for needless_pass_by_ref_mut and non_canonical_partial_ord_impl as the linked issues appear to have been resolved in [0] and [1] respectively - Fixes apparently legitimate issues now reported by clippy Test Plan: CI [0] rust-lang/rust-clippy#11492 [1] rust-lang/rust-clippy#11188 Closes WEB-1732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
Test Plan: CI
[0] rust-lang/rust-clippy#11492
[1] rust-lang/rust-clippy#11188
Closes WEB-1732