Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ICE by u64::try_from(<u128>) #11517

Merged
merged 1 commit into from Sep 18, 2023
Merged

fix ICE by u64::try_from(<u128>) #11517

merged 1 commit into from Sep 18, 2023

Conversation

kiscad
Copy link
Contributor

@kiscad kiscad commented Sep 16, 2023

changelog: Fix the ICE in [cast_possible_truncation], when the Shr bits is larger than u64::MAX

fix #11426

@rustbot
Copy link
Collaborator

rustbot commented Sep 16, 2023

r? @Centri3

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 16, 2023
@kiscad kiscad closed this Sep 17, 2023
@kiscad kiscad reopened this Sep 17, 2023
@Alexendoo
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Collaborator

bors commented Sep 18, 2023

📌 Commit 3665a41 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 18, 2023

⌛ Testing commit 3665a41 with merge 2a0795f...

bors added a commit that referenced this pull request Sep 18, 2023
@bors
Auto merge of #11517 - mojave2:issue-11426, r=Alexendoo
2a0795f 
fix ICE by `u64::try_from(<u128>)`

changelog: Fix the ICE in [`cast_possible_truncation`], when the `Shr` bits is larger than `u64::MAX`

fix #11426
@bors
Copy link
Collaborator

bors commented Sep 18, 2023

💔 Test failed - checks-action_remark_test

@blyxyas
Copy link
Member

blyxyas commented Sep 18, 2023

Spurious error.
@bors r=Alexendoo

@bors
Copy link
Collaborator

bors commented Sep 18, 2023

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Collaborator

bors commented Sep 18, 2023

📌 Commit 3665a41 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 18, 2023

⌛ Testing commit 3665a41 with merge fd30f31...

bors added a commit that referenced this pull request Sep 18, 2023
@bors
Auto merge of #11517 - mojave2:issue-11426, r=Alexendoo
fd30f31 
fix ICE by `u64::try_from(<u128>)`

changelog: Fix the ICE in [`cast_possible_truncation`], when the `Shr` bits is larger than `u64::MAX`

fix #11426
@bors
Copy link
Collaborator

bors commented Sep 18, 2023

💔 Test failed - checks-action_remark_test

@blyxyas
Copy link
Member

blyxyas commented Sep 18, 2023

This PR shouldn't even trigger the remark job -.-
Probably an infra bug

@Alexendoo
Copy link
Member

Alexendoo commented Sep 18, 2023 •
edited

The PR didn't, but the bors build will since it pushes to the auto branch. Looks like we need to update node, I'll get on that

edit: #11531

@Alexendoo
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Sep 18, 2023

⌛ Testing commit 3665a41 with merge 4022591...

@bors
Copy link
Collaborator

bors commented Sep 18, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 4022591 to master...

@bors bors merged commit 4022591 into rust-lang:master Sep 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexendoo Alexendoo Alexendoo left review comments

Assignees

@Centri3 Centri3

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE shift too high: TryFromIntError(())
6 participants
@kiscad @rustbot @Alexendoo @bors @blyxyas @Centri3