Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let_and_return: Wrap with parenthesis if necessary #11584

Merged
merged 1 commit into from Oct 26, 2023

Conversation

koka831
Copy link
Contributor

@koka831 koka831 commented Sep 29, 2023

changelog: [let_and_return]: Wrap suggestion with parenthesis if necessary

r? @Centri3

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 29, 2023
@blyxyas
Copy link
Member

blyxyas commented Oct 26, 2023

Seems like Catherine is having some problems with this review (she's busy). I'll take it from now on to keep things moving.
r? @blyxyas

@rustbot rustbot assigned blyxyas and unassigned Centri3 Oct 26, 2023
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Oct 26, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 26, 2023

📌 Commit f4a8b12 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 26, 2023

⌛ Testing commit f4a8b12 with merge 0da4dab...

@bors
Copy link
Collaborator

bors commented Oct 26, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 0da4dab to master...

@bors bors merged commit 0da4dab into rust-lang:master Oct 26, 2023
5 checks passed
@koka831
Copy link
Contributor Author

koka831 commented Oct 26, 2023

@blyxyas thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some more let_and_return funny-business
5 participants