Move needless_pass_by_ref_mut: suspicious -> nursery
#11596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Jarcho (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Jarcho
added
the
beta-nominated
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Oct 2, 2023
Move `needless_pass_by_ref_mut`: `suspicious` -> `nursery` [Related to [this Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/needless_pass_by_ref_mut.20isn't.20ready.20for.20stable)] `needless_pass_by_ref_mut` has been released with some important bugs (notably having a lot of reported false positives and an ICE). So it may not be really ready for being in stable until these problems are solved. This PR changes the lint's category from `suspicious` to `nursery`, just that. changelog: none
|
@bors r- |
|
☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
The changes to the other tests aren't needed, they should only need to be blessed. |
|
Oh, you're right. I'll change those right now. |
blyxyas
force-pushed
the
fix-fp-needless_pass_by_ref_mut
branch
from
2705d62
to
07e6329
Compare
|
One more time. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Oct 2, 2023
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Oct 3, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 3, 2023
…Simulacrum [stable] 1.73.0 release Still needs a clippy backport (rust-lang/rust-clippy#11596). r? `@Mark-Simulacrum`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 3, 2023
…Simulacrum [stable] 1.73.0 release Still needs a clippy backport (rust-lang/rust-clippy#11596). r? `@Mark-Simulacrum`
xobs
pushed a commit
to betrusted-io/rust
that referenced
this pull request
Oct 3, 2023
plietar
pushed a commit
to plietar/rust
that referenced
this pull request
Oct 18, 2023
flip1995
removed
the
beta-nominated
flip1995
added
the
beta-accepted
xFrednet
removed
the
beta-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Related to this Zulip thread]
needless_pass_by_ref_muthas been released with some important bugs (notably having a lot of reported false positives and an ICE). So it may not be really ready for being in stable until these problems are solved. This PR changes the lint's category fromsuspicioustonursery, just that.changelog: none