Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/11134 #11664

Merged
merged 2 commits into from Oct 13, 2023
Merged

Fix/11134 #11664

merged 2 commits into from Oct 13, 2023

Conversation

koka831
Copy link
Contributor

@koka831 koka831 commented Oct 13, 2023

Fix #11134

Hir of qpath will be TypeRelative(Ty { kind: Path(LangItem... when a closure contains macro (e.g. #11651) and #11134, it causes panic.
This PR avoids panicking and emitting incomplete path string when qpath contains LangItem.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Oct 13, 2023

r? @blyxyas

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 13, 2023
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks ❤️! (=^‥^=)

@blyxyas
Copy link
Member

blyxyas commented Oct 13, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 13, 2023

📌 Commit 9fc717d has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 13, 2023

⌛ Testing commit 9fc717d with merge c40359d...

@bors
Copy link
Collaborator

bors commented Oct 13, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing c40359d to master...

@bors bors merged commit c40359d into rust-lang:master Oct 13, 2023
5 checks passed
@koka831 koka831 deleted the fix/11134 branch October 13, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: path_to_string: called for lang item qpath author on for-loop
4 participants