Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing parenthesis in suboptimal floating point help #11724

Merged
merged 1 commit into from Oct 28, 2023
Merged

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Oct 27, 2023

This fixes #11559 by adding a branch in the Neg implementation for Sugg that adds parentheses to keep precedence in order, then using that in the suggestion. I also removed some needless .to_string()s while I was at it.


changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 27, 2023
@llogiq
Copy link
Contributor Author

llogiq commented Oct 28, 2023

I think Jarcho may be overworked a bit, so

@bors r? @blyxyas

@rustbot rustbot assigned blyxyas and unassigned Jarcho Oct 28, 2023
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Oct 28, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 28, 2023

📌 Commit 1ed1001 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 28, 2023

⌛ Testing commit 1ed1001 with merge 5852ca8...

@bors
Copy link
Collaborator

bors commented Oct 28, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 5852ca8 to master...

@bors bors merged commit 5852ca8 into master Oct 28, 2023
6 checks passed
@llogiq llogiq deleted the fix-11559 branch October 28, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mul_add suggestion from suboptimal_flops applies unary minus to unsigned integer, leading to compiler error
5 participants