Fixes to manual_let_else
's divergence check
#11787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to the divergence check in
manual_let_else
and moves it the implementation toclippy_utils
since it's generally useful:break
andcontinue
expressions.e.g. The first loop is divergent, but the second is not.
e.g. The following is not considered divergent by rustc as the inner block has a result type of
()
:e.g. The following would be a divergent if a semicolon were added after the
if
expression:changelog: None