Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New lint manual_checked_op #11789

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Nov 10, 2023

Based off the changes in #11787. Still a fair bit of work to do to catch more patterns.

changelog: Add new lint manual_checked_op

@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2023

r? @Centri3

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 10, 2023
@bors
Copy link
Collaborator

bors commented Nov 14, 2023

☔ The latest upstream changes (presumably #11791) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Nov 19, 2023

☔ The latest upstream changes (presumably #11781) made this pull request unmergeable. Please resolve the merge conflicts.

@xFrednet
Copy link
Member

xFrednet commented Apr 1, 2024

Da, how did this PR reach 1700+ changes o.O

Well, my actual question is @Jarcho do you plan to continue this PR? And is it ready for a review?

@y21
Copy link
Member

y21 commented Apr 1, 2024

(also maybe this should be named manual_checked_arithmetic for consistency with manual_saturating_arithmetic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants