New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend result_map_or_into_option
lint to handle Result::map_or_else(|_| None, Some)
#11845
Extend result_map_or_into_option
lint to handle Result::map_or_else(|_| None, Some)
#11845
Conversation
9e56112
to
3bc412a
Compare
Re-assigning to someone else as r? @flip1995 |
3bc412a
to
c5cd899
Compare
f4815ed
to
773db59
Compare
I added the |
a60fd9a
to
1b17a5b
Compare
Applied your suggestions, the code is much shorter now. :) |
LGTM. r=me with above comment addressed @bors delegate+ |
✌️ @GuillaumeGomez, you can now approve this pull request! If @flip1995 told you to " |
1b17a5b
to
1384ebe
Compare
…sion, r=flip1995 Extend `result_map_or_into_option` lint to handle `Result::map_or_else(|_| None, Some)` Fixes #10365. As indicated in the title, it extends the `result_map_or_into_option` lint to handle `Result::map_or_else(|_| None, Some)`. changelog: extension of the `result_map_or_into_option` lint to handle `Result::map_or_else(|_| None, Some)` r? `@blyxyas`
💔 Test failed - checks-action_test |
Failed because of:
Not related to this PR but just in case I'll rebase. |
1384ebe
to
5d330d0
Compare
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
The rebase fixed it. Oh well. Dark magic. |
Improve error messages format Following review in #11845, since there is already suggestions, no need to add the second part of the sentence every time. r? `@flip1995` changelog: Improve some error messages
Fixes #10365.
As indicated in the title, it extends the
result_map_or_into_option
lint to handleResult::map_or_else(|_| None, Some)
.changelog: extension of the
result_map_or_into_option
lint to handleResult::map_or_else(|_| None, Some)
r? @blyxyas