Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc_markdown]: Add "WebGL2", "WebGPU" to default doc_valid_idents #12018

Merged

Conversation

waywardmonkeys
Copy link
Contributor

changelog: [doc_markdown]: Add "WebGL2", "WebGPU" to default doc_valid_idents

@rustbot
Copy link
Collaborator

rustbot commented Dec 26, 2023

r? @blyxyas

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 26, 2023
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Dec 26, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 26, 2023

📌 Commit 6ed6ad3 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 26, 2023

⌛ Testing commit 6ed6ad3 with merge cf0547f...

bors added a commit that referenced this pull request Dec 26, 2023
…2, r=blyxyas

[doc_markdown]: Add "WebGL2", "WebGPU" to default `doc_valid_idents`

changelog: [`doc_markdown`]: Add "WebGL2", "WebGPU" to default `doc_valid_idents`
@bors
Copy link
Collaborator

bors commented Dec 26, 2023

💔 Test failed - checks-action_test

@waywardmonkeys
Copy link
Contributor Author

@blyxyas Is there anything that I need to do to fix this? (And is it too late for 1.75?)

@blyxyas
Copy link
Member

blyxyas commented Dec 26, 2023

You need to run cargo collect-medatada. I don't think it's too late for 1.75, let's try.

@blyxyas
Copy link
Member

blyxyas commented Dec 26, 2023

@waywardmonkeys ?

@waywardmonkeys
Copy link
Contributor Author

Sorry, I am away from wifi for a couple of hours

@waywardmonkeys
Copy link
Contributor Author

@blyxyas Sorry about the delay. Rebased forward, ran that command, force pushed.

@blyxyas
Copy link
Member

blyxyas commented Dec 27, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 27, 2023

📌 Commit f48b850 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 27, 2023

⌛ Testing commit f48b850 with merge 677f8d8...

@bors
Copy link
Collaborator

bors commented Dec 27, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 677f8d8 to master...

@bors bors merged commit 677f8d8 into rust-lang:master Dec 27, 2023
8 checks passed
@waywardmonkeys waywardmonkeys deleted the doc-markdown-allow-webgpu-webgl2 branch December 27, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants