Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle type relative in trait_duplication_in_bounds lint #12155

Merged
merged 2 commits into from Jan 17, 2024

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jan 16, 2024

Fixes #9961.

The generic bounds were not correctly checked and left out QPath::TypeRelative, making different bounds look the same and generating invalid errors (and fix).

r? @blyxyas

changelog: [trait_duplication_in_bounds]: Correctly handle type relative.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 16, 2024
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Jan 17, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 17, 2024

📌 Commit 7217c22 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 17, 2024

⌛ Testing commit 7217c22 with merge 2067fe4...

@bors
Copy link
Collaborator

bors commented Jan 17, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 2067fe4 to master...

@bors bors merged commit 2067fe4 into rust-lang:master Jan 17, 2024
5 checks passed
@GuillaumeGomez GuillaumeGomez deleted the fix-9961 branch January 17, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trait_duplication_in_bounds breaks code
4 participants