Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nonminimal_bool lint regression #12372

Merged
merged 2 commits into from Feb 28, 2024
Merged

Fix nonminimal_bool lint regression #12372

merged 2 commits into from Feb 28, 2024

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Feb 28, 2024 •
edited

Fixes #12371.
Fixes #12369.

cc @RalfJung

The problem was an invalid condition. Shame on me...

changelog: Fix nonminimal_bool lint regression

@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 28, 2024
@flip1995
Copy link
Member

@bors r+

Thanks!

@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 28, 2024
Closed
@GuillaumeGomez
Copy link
Member Author

Not sure that bors got the message?

@flip1995
Copy link
Member

Hm yeah, bors queue didn't list this PR. I'm re-syncing the queue.

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 28, 2024

📌 Commit 8473716 has been approved by flip1995

It is now in the queue for this repository.

bors added a commit that referenced this pull request Feb 28, 2024
@bors
Auto merge of #12372 - GuillaumeGomez:fix-nonminimal_bool-regression,…
d34b3f4 
… r=flip1995

Fix `nonminimal_bool` lint regression

Fixes #12371.
Fixes #12369.

cc `@RalfJung`

The problem was an invalid condition. Shame on me...

changelog: Fix `nonminimal_bool` lint regression
@bors
Copy link
Collaborator

bors commented Feb 28, 2024

⌛ Testing commit 8473716 with merge d34b3f4...

@bors
Copy link
Collaborator

bors commented Feb 28, 2024

💔 Test failed - checks-action_test

@GuillaumeGomez
Copy link
Member Author

mac flakyness I suppose...

@flip1995
Copy link
Member

@bors retry (still didn't get to looking into the mac issue...)

@bors
Copy link
Collaborator

bors commented Feb 28, 2024

⌛ Testing commit 8473716 with merge e450a27...

@bors
Copy link
Collaborator

bors commented Feb 28, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing e450a27 to master...

@bors bors merged commit e450a27 into rust-lang:master Feb 28, 2024
5 checks passed
@GuillaumeGomez GuillaumeGomez deleted the fix-nonminimal_bool-regression branch February 28, 2024 15:39
@Ethiraric Ethiraric mentioned this pull request Feb 29, 2024
Closed
@y21 y21 mentioned this pull request Mar 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
5 participants
@GuillaumeGomez @rustbot @flip1995 @bors @blyxyas