Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added msrv to threadlocal initializer check #12405

Merged
merged 1 commit into from Mar 3, 2024
Merged

Conversation

m-rph
Copy link
Contributor

@m-rph m-rph commented Mar 3, 2024

closes: #12404
changelog:[thread_local_initializer_can_be_made_const]: Check for MSRV (>= 1.59) before processing.

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 3, 2024
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Mar 3, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 3, 2024

📌 Commit 08459b4 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 3, 2024

⌛ Testing commit 08459b4 with merge b1e4500...

bors added a commit that referenced this pull request Mar 3, 2024
Added msrv to threadlocal initializer check

closes: #12404
@bors
Copy link
Collaborator

bors commented Mar 3, 2024

💔 Test failed - checks-action_test

@blyxyas
Copy link
Member

blyxyas commented Mar 3, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 3, 2024

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 3, 2024

📌 Commit 08459b4 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 3, 2024

⌛ Testing commit 08459b4 with merge aceeb54...

@bors
Copy link
Collaborator

bors commented Mar 3, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing aceeb54 to master...

@bors bors merged commit aceeb54 into rust-lang:master Mar 3, 2024
5 checks passed
@m-rph
Copy link
Contributor Author

m-rph commented Mar 7, 2024

@rustbot label +beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 7, 2024
@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Mar 14, 2024
@flip1995
Copy link
Member

rust-lang/rust#122510

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2024
…ulacrum

[beta] Clippy backports

Backports included in this PR:

- rust-lang/rust-clippy#12276 Fixing the lint on some platforms before hitting stable
- rust-lang/rust-clippy#12405 Respect MSRV before hitting stable
- rust-lang/rust-clippy#12266 Fixing an (unlikely) ICE
- rust-lang/rust-clippy#12177 Fixing FPs before hitting stable

Each backport on its own might not warrant a backport, but the collection of those are nice QoL fixes for Clippy users, before those bugs hit stable.

All of those commits are already on `master`.

r? `@Mark-Simulacrum`
@xFrednet xFrednet removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thread_local_initializer_can_be_made_const should respect MSRV
6 participants