[manual_retain
]: Fix duplicate diagnostics
#12452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #12379
The first lint guard executed in
LateLintPass::check_expr
was testing if the parent was of typeExprKind::Assign
. This meant the lint emitted on both sides of the assignment operator whencheck_expr
is called on eitherExpr
. The guard in the fix only lints once when theExpr
is of kindAssign
.changelog: Fix duplicate lint diagnostic emission from [
manual_retain
]