Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [dbg_macro] FN when dbg is inside some complex macros #12482

Merged
merged 3 commits into from
Mar 17, 2024

Conversation

J-ZhengLi
Copy link
Member

@J-ZhengLi J-ZhengLi commented Mar 14, 2024

fixes: #12131

It appears that [root_macro_call_first_node] only detects println! in the following example:

println!("{:?}", dbg!(s));

changelog: fix [dbg_macro] FN when dbg is inside some complex macros

(re-opening b'cuz bors doesn't like my previous one)

@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 14, 2024
@J-ZhengLi
Copy link
Member Author

r? @Jarcho

@rustbot rustbot assigned Jarcho and unassigned dswij Mar 14, 2024
@J-ZhengLi
Copy link
Member Author

still showing a big red x next to my first commit though, not sure what's happening @Jarcho , I'll try modify that commit message or squash them to see if that go away.

@Jarcho
Copy link
Contributor

Jarcho commented Mar 17, 2024

Lets try this again. @bors r+

@bors
Copy link
Collaborator

bors commented Mar 17, 2024

📌 Commit fe4e0ac has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 17, 2024

⌛ Testing commit fe4e0ac with merge 12ecaa8...

@bors
Copy link
Collaborator

bors commented Mar 17, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 12ecaa8 to master...

@bors bors merged commit 12ecaa8 into rust-lang:master Mar 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbg_macro ignored in macro call sites
5 participants