fix [undocumented_unsafe_blocks] FP with trait/impl items
#12672
+146
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Alexendoo
reviewed
Apr 12, 2024
Comment on lines
733
to
750
| fn hir(node: &'hir Node<'hir>) -> Option<Self> { | ||
| let (owner_id, kind, span) = match node { | ||
| Node::Item(item) => (item.owner_id, item.kind.into(), item.span), | ||
| Node::TraitItem(ti) => (ti.owner_id, ti.kind.into(), ti.span), | ||
| Node::ImplItem(ii) => (ii.owner_id, ii.kind.into(), ii.span), | ||
| _ => return None, | ||
| }; | ||
| Some(Self { owner_id, kind, span }) | ||
| } | ||
|
|
||
| fn is_const_or_static(&self) -> bool { | ||
| matches!( | ||
| self.kind, | ||
| ItemAlikeKind::Item(ItemKind::Const(..) | ItemKind::Static(..)) | ||
| | ItemAlikeKind::ImplItem(hir::ImplItemKind::Const(..)) | ||
| | ItemAlikeKind::TraitItem(hir::TraitItemKind::Const(..)) | ||
| ) | ||
| } |
There was a problem hiding this comment.
These could be two standalone functions without the new types/macros, something like
fn item_a_like(node: &Node) -> Option<(Span, HirId)> { ... }
fn is_const_or_static_item_a_like(node: &Node) -> bool { ... }Also worth mentioning that you can use .into() to go from an OwnerId to a HirId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #11709
do-over of #11813 , I was trying to fix multiple problems at once thus making that PR hard to review, also hard to maintain after so many conflicts... So, here's a new one, should be a bit simpler to review the changes.
r? @Alexendoo if you don't mind?
changelog: fix [
undocumented_unsafe_blocks] FP with trait/impl items