fix [undocumented_unsafe_block] and [unnecessary_safety_comment] not detecting associated constants
#11813
Conversation
|
r? @blyxyas (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
J-ZhengLi
force-pushed
the
issue11709
branch
from
fa67fbb
to
e8f5cd5
Compare
|
Sorry, I don't really have the time to review a PR with this size (=^-ω-^=) I have some important deadlines before mid-december and a lot of work. Sorry for the wait ❤️ r? @rust-lang/clippy |
No worries~ |
J-ZhengLi
force-pushed
the
issue11709
branch
2 times, most recently
from
0fa2b78
to
030d99a
Compare
|
☔ The latest upstream changes (presumably #11903) made this pull request unmergeable. Please resolve the merge conflicts. |
Well, I mistakenly thinking it was the test file for [`undocumented_unsafe_blocks`] at first... but it doesn't make things worse anyway, so I keep them lol.
…not detecting associated constants
J-ZhengLi
force-pushed
the
issue11709
branch
from
3657f5e
to
c85450b
Compare
|
☔ The latest upstream changes (presumably #12306) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Hey @J-ZhengLi, this is a ping from triage, since there hasn't been any activity in some time. Could you rebase on master? @rustbot author |
rustbot
added
S-waiting-on-author
|
Oh nooo, because I already forgot what I did thus it's kinda hard to distinguish which lines are mine and which are add by others after this PR, at this point it might even be easier if I redo the whole thing (but with less changes I promise). It should be a simple fix tho, I don't know what have I done to make it this complicated 🤦♂️ I'm gonna close this and open a new PR tomorrow (hopefully) fixing this again, and sorry @Alexendoo for wasting effort XD |
fixes: #11709
changelog: fix FP on [
undocumented_unsafe_block] and [unnecessary_safety_comment]