Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy::single_match(_else) may be machine applicable #12726

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

kornelski
Copy link
Contributor

changelog: [`single_match`]: make the lint machine-applicable
changelog: [`single_match_else`]: make the lint machine-applicable

The lint doesn't use placeholders. I've tried it on my codebases, and all instances of it applied without problems.

@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 27, 2024
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm.... I've been trying to test this, but I think it's alright. It shouldn't cause any issues :) ❤️

@blyxyas
Copy link
Member

blyxyas commented Apr 29, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 29, 2024

📌 Commit b700d9c has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 29, 2024

⌛ Testing commit b700d9c with merge 9e02abe...

@bors
Copy link
Collaborator

bors commented Apr 29, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 9e02abe to master...

@bors bors merged commit 9e02abe into rust-lang:master Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants