Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for Clippy 1.78 🪄 #12735

Merged
merged 3 commits into from May 2, 2024
Merged

Conversation

xFrednet
Copy link
Member

@xFrednet xFrednet commented Apr 29, 2024

Roses and Violets have colors,
Red and Blue are the two,
I'm getting to the end of my masters,
what a cool goal to pursue


The cat of this release is: Shadow submitted by @benwh1:

The cats of this Clippy release

Cats for the next release can be nominated in the comments :D


changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 29, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once we confirm the arg changes to be correct

@llogiq
Copy link
Contributor

llogiq commented Apr 30, 2024

IMG20240422132052.jpg

Maunzer (a.k.a. Tom), here shown testing the borrowed_box lint

@blyxyas
Copy link
Member

blyxyas commented Apr 30, 2024

image
Keepy

Co-authored-by: Timo <30553356+y21@users.noreply.github.com>
@xFrednet
Copy link
Member Author

xFrednet commented May 2, 2024

@flip1995 decided to leave the cargo-clippy argument thing from this changelog in favor of a more coordinated announcement. The rest was already approved, so I'll merge it now.

Thank you for the cat picture :3

@bors r=dswij

@bors
Copy link
Collaborator

bors commented May 2, 2024

📌 Commit 5c23f13 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 2, 2024

⌛ Testing commit 5c23f13 with merge 546408b...

@bors
Copy link
Collaborator

bors commented May 2, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 546408b to master...

@bors bors merged commit 546408b into rust-lang:master May 2, 2024
8 checks passed
@xFrednet xFrednet deleted the changelog-1-78 branch May 2, 2024 11:07
@Centri3
Copy link
Member

Centri3 commented May 7, 2024

1-1

Late to the party this time. But uncovered old photos of kittens when I was 10-11 :)

Gracie and her kittens

@xFrednet
Copy link
Member Author

At RustNL I got a truly magnificent cat nomination =^.^=

I present you the one and only @jyn514 ♥️

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants