Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add applicability to lint name suggestion #3667

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Jan 16, 2019

No description provided.

@phansch
Copy link
Member

phansch commented Jan 17, 2019

@bors r+ thanks!

@bors
Copy link
Collaborator

bors commented Jan 17, 2019

📌 Commit 8fba46a has been approved by phansch

@bors
Copy link
Collaborator

bors commented Jan 17, 2019

⌛ Testing commit 8fba46a with merge 59b250e...

bors added a commit that referenced this pull request Jan 17, 2019
add applicability to lint name suggestion
@bors
Copy link
Collaborator

bors commented Jan 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 59b250e to master...

@bors bors merged commit 8fba46a into rust-lang:master Jan 17, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 19, 2019
…enkov

add applicability to remaining suggestions

Fixes rust-lang#50723.

I noticed that the suggestion methods on `DiagnosticBuilder` weren't actually deprecated due to rust-lang#57679. This PR deprecates them properly and fixes the remaining usages.

There's also a PR for clippy at rust-lang/rust-clippy#3667.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants