add applicability to remaining suggestions #57699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
|
||
| forward!( | ||
| #[deprecated(note = "Use `span_suggestion_with_applicability`")] | ||
| pub fn span_suggestion( |
There was a problem hiding this comment.
I'd personally just remove them and rename span_suggestion_with_applicability -> span_suggestion.
We don't provide any stability guarantees for compiler internals after all.
There was a problem hiding this comment.
I want to do that in a followup PR, after clippy updates.
There was a problem hiding this comment.
@euclio in that case you might want to leave a FIXME
|
@bors r+ |
|
📌 Commit 02843d9 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 19, 2019
…enkov add applicability to remaining suggestions Fixes rust-lang#50723. I noticed that the suggestion methods on `DiagnosticBuilder` weren't actually deprecated due to rust-lang#57679. This PR deprecates them properly and fixes the remaining usages. There's also a PR for clippy at rust-lang/rust-clippy#3667.
bors
added a commit
that referenced
this pull request
Jan 19, 2019
Rollup of 7 pull requests Successful merges: - #57486 (Simplify `TokenStream` some more) - #57502 (make trait-aliases work across crates) - #57598 (Add missing unpretty option help message) - #57649 (privacy: Account for associated existential types) - #57659 (Fix release manifest generation) - #57699 (add applicability to remaining suggestions) - #57719 (Tweak `expand_node`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50723.
I noticed that the suggestion methods on
DiagnosticBuilderweren't actually deprecated due to #57679. This PR deprecates them properly and fixes the remaining usages.There's also a PR for clippy at rust-lang/rust-clippy#3667.