New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add applicability to remaining suggestions #57699

Merged
merged 1 commit into from Jan 19, 2019

Conversation

Projects
None yet
6 participants
@euclio
Copy link
Contributor

euclio commented Jan 17, 2019

Fixes #50723.

I noticed that the suggestion methods on DiagnosticBuilder weren't actually deprecated due to #57679. This PR deprecates them properly and fixes the remaining usages.

There's also a PR for clippy at rust-lang/rust-clippy#3667.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 17, 2019

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)


forward!(
#[deprecated(note = "Use `span_suggestion_with_applicability`")]
pub fn span_suggestion(

This comment has been minimized.

@petrochenkov

petrochenkov Jan 17, 2019

Contributor

I'd personally just remove them and rename span_suggestion_with_applicability -> span_suggestion.
We don't provide any stability guarantees for compiler internals after all.

This comment has been minimized.

@euclio

euclio Jan 17, 2019

Author Contributor

I want to do that in a followup PR, after clippy updates.

This comment has been minimized.

@Centril

Centril Jan 17, 2019

Contributor

@euclio in that case you might want to leave a FIXME

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 17, 2019

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Jan 17, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 17, 2019

📌 Commit 02843d9 has been approved by petrochenkov

Centril added a commit to Centril/rust that referenced this pull request Jan 19, 2019

Rollup merge of rust-lang#57699 - euclio:applicability-ify, r=petroch…
…enkov

add applicability to remaining suggestions

Fixes rust-lang#50723.

I noticed that the suggestion methods on `DiagnosticBuilder` weren't actually deprecated due to rust-lang#57679. This PR deprecates them properly and fixes the remaining usages.

There's also a PR for clippy at rust-lang/rust-clippy#3667.

bors added a commit that referenced this pull request Jan 19, 2019

Auto merge of #57755 - Centril:rollup, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #57486 (Simplify `TokenStream` some more)
 - #57502 (make trait-aliases work across crates)
 - #57598 (Add missing unpretty option help message)
 - #57649 (privacy: Account for associated existential types)
 - #57659 (Fix release manifest generation)
 - #57699 (add applicability to remaining suggestions)
 - #57719 (Tweak `expand_node`)

Failed merges:

r? @ghost

@bors bors merged commit 02843d9 into rust-lang:master Jan 19, 2019

@euclio euclio deleted the euclio:applicability-ify branch Jan 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment