Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Cleanup one part of assign_ops lint #3852

Merged
merged 2 commits into from Mar 9, 2019

Conversation

Projects
None yet
3 participants
@phansch
Copy link
Collaborator

commented Mar 7, 2019

Removes a lot of indentation and separates lint emission from lint
logic. Only touches the hir::ExprKind::AssignOp part of the lint.

@phansch phansch force-pushed the phansch:refactor_assign_ops branch from f9cbd8a to 866c895 Mar 7, 2019

Refactor: Cleanup one part of assign_ops lint
Removes a lot of indentation and separates lint emission from lint
logic. Only touches the `hir::ExprKind::AssignOp` part of the lint.

@phansch phansch force-pushed the phansch:refactor_assign_ops branch from 866c895 to 5c9221f Mar 8, 2019

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented Mar 9, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

📌 Commit 9494f22 has been approved by flip1995

flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Mar 9, 2019

Rollup merge of rust-lang#3852 - phansch:refactor_assign_ops, r=flip1995
Refactor: Cleanup one part of assign_ops lint

Removes a lot of indentation and separates lint emission from lint
logic. Only touches the `hir::ExprKind::AssignOp` part of the lint.

@flip1995 flip1995 referenced this pull request Mar 9, 2019

Merged

Rollup of 3 pull requests #3861

bors added a commit that referenced this pull request Mar 9, 2019

Auto merge of #3861 - flip1995:rollup, r=flip1995
Rollup of 3 pull requests

Successful merges:

 - #3851 (Refactor: Extract `trait_ref_of_method` function)
 - #3852 (Refactor: Cleanup one part of assign_ops lint)
 - #3857 (Document match_path, improve match_qpath docs)

Failed merges:

r? @ghost

@bors bors merged commit 9494f22 into rust-lang:master Mar 9, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.