Change naive_bytecount applicability to MaybeIncorrect #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use `MachineApplicable` here as applying the fix will cause another error because `bytecount` would first have to be added to the Cargo.toml.
phansch
changed the title
39 tasks
|
@bors r+ |
|
📌 Commit 01ea9bd has been approved by |
bors
added a commit
that referenced
this pull request
Apr 18, 2019
Change naive_bytecount applicability to MaybeIncorrect We can't use `MachineApplicable` here as applying the fix will cause another error because `bytecount` would first have to be added to the Cargo.toml. Example: ``` error: You appear to be counting bytes the naive way --> $DIR/bytecount.rs:5:13 | LL | let _ = x.iter().filter(|&&a| a == 0).count(); // naive byte count | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(x, 0)` ``` Just replacing it with the suggestion is not enough. cc #3630
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use
MachineApplicablehere as applying the fix will causeanother error because
bytecountwould first have to be added to theCargo.toml.
Example:
Just replacing it with the suggestion is not enough.
cc #3630