Join GitHub today
Tracking Issue: Fixing broken lint suggestions #3630
Now that we have rustfix integrated in our testsuite, we can use it to make sure that the suggestions we provide are valid rust code. This tracking issue is meant to give an overview of how many lints currently provide incorrect suggestions.
Below is the list of tests that include
If you want to help out with this, feel free to select one file that is not fixed and leave a comment below. Smaller files are most likely easier to fix.
Files that test lints which need to be fixed
@flip1995 Was already doing that, but I guess I can just edit my comment while I'm working through the list.
Fixing this myself (PR: #3658)
Not yet fixed
Notes on the process
That's the whole list! Some of these are tricky cases:
added a commit
Jan 14, 2019
Sometimes this is unavoidable. If it is somehow possible we should maybe set all Clippy lints to warn/allow in the second pass, where the
If that's the case, the lint shouldn't be