Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix #3981 #4026

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Attempt to fix #3981 #4026

merged 1 commit into from
Apr 25, 2019

Conversation

cemiloten
Copy link
Contributor

@cemiloten cemiloten commented Apr 24, 2019 •
edited by flip1995
Loading

Fixes #3981

Hi, hopefully this is correct, happy to have feedback.

changelog: Don't trigger unnecessary_cast inside a macro

@oli-obk
Copy link
Contributor

oli-obk commented Apr 24, 2019

Looks good. You just need to run rustfmt on the test, then it should all check out

@phansch
Copy link
Member

phansch commented Apr 24, 2019

You'll need to update the .stderr file as well again (using ./tests/ui/update-all-references.sh) since running rustfmt changed the line numbers in the test file.

@phansch phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Apr 24, 2019
flip1995
flip1995 approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM now! Do you mind squashing the commits?

@cemiloten
Copy link
Contributor Author

I think it should be good now... First PR yay!

@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 25, 2019

📌 Commit 8eae2d3 has been approved by flip1995

bors added a commit that referenced this pull request Apr 25, 2019
@bors
Auto merge of #4026 - cemiloten:working-on-#3981, r=flip1995
6a0105e 
Attempt to fix #3981

Fixes #3981

Hi, hopefully this is correct, happy to have feedback.

changelog: Don't trigger `unnecessary_cast` inside a macro
@bors
Copy link
Collaborator

bors commented Apr 25, 2019

⌛ Testing commit 8eae2d3 with merge 6a0105e...

@bors
Copy link
Collaborator

bors commented Apr 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 6a0105e to master...

@bors bors merged commit 8eae2d3 into rust-lang:master Apr 25, 2019
@cemiloten cemiloten deleted the working-on-#3981 branch April 25, 2019 12:00
@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 25, 2019

Thank you @cemiloten !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unnecessary_cast false positives in macros
6 participants
@cemiloten @oli-obk @phansch @flip1995 @bors @gnzlbg