Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix #3981 #4026

Merged
merged 1 commit into from Apr 25, 2019

Conversation

Projects
None yet
6 participants
@cemiloten
Copy link
Contributor

commented Apr 24, 2019

Fixes #3981

Hi, hopefully this is correct, happy to have feedback.

changelog: Don't trigger unnecessary_cast inside a macro

@oli-obk

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

Looks good. You just need to run rustfmt on the test, then it should all check out

@phansch

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

You'll need to update the .stderr file as well again (using ./tests/ui/update-all-references.sh) since running rustfmt changed the line numbers in the test file.

@flip1995
Copy link
Collaborator

left a comment

Thanks, LGTM now! Do you mind squashing the commits?

@cemiloten cemiloten force-pushed the cemiloten:working-on-#3981 branch from a6bb32c to 8eae2d3 Apr 25, 2019

@cemiloten

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

I think it should be good now... First PR yay!

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

Thanks!

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

📌 Commit 8eae2d3 has been approved by flip1995

bors added a commit that referenced this pull request Apr 25, 2019

Auto merge of #4026 - cemiloten:working-on-#3981, r=flip1995
Attempt to fix #3981

Fixes #3981

Hi, hopefully this is correct, happy to have feedback.

changelog: Don't trigger `unnecessary_cast` inside a macro
@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

⌛️ Testing commit 8eae2d3 with merge 6a0105e...

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 6a0105e to master...

@bors bors merged commit 8eae2d3 into rust-lang:master Apr 25, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

@cemiloten cemiloten deleted the cemiloten:working-on-#3981 branch Apr 25, 2019

@gnzlbg

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Thank you @cemiloten !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.