Implement better help for clippy-driver #4175
Conversation
flip1995
added
the
S-waiting-on-review
There was a problem hiding this comment.
LGTM
cc @Manishearth since you opened the corresponding issue.
|
still missing the default lint levels and the group output but its shaping up :)
|
|
and now we have groups, just have to find lint levels then its ready for review and mergemeby
|
src/driver.rs
Outdated
| print_lints(&lints); | ||
|
|
||
| let max_name_len = std::cmp::max( | ||
| "warnings".len(), |
There was a problem hiding this comment.
is there a clippy::warnings group?
There was a problem hiding this comment.
No, there's only clippy::all which is all warn-by-default and deny-by-default lints. You can find all available lint groups in the README:
- clippy::all
- clippy::correctness (deny-by-default)
- clippy::style (warn)
- clippy::complexity (warn)
- clippy::perf (warn)
- clippy::pedantic (allow)
- clippy::nursery (allow)
- clippy::cargo (allow)
There's also clippy::restriction, which is allow-by-default and lints where it doesn't make sense to enable the whole group.
There was a problem hiding this comment.
okay, I bring this up because rustc has a hard coded bit for their warnings group because its otherwise not included with their other lint groups, it looks like we've got everything in our groups except all, so I'm going to treat all like our version of warning and include it in the output the same way that rustc does.
Everything else will get included programatically.
Co-Authored-By: Philipp Krones <hello@philkrones.com>
|
@bors r+ |
|
📌 Commit 2719c1e has been approved by |
Implement better help for clippy-driver #4173
| sorted_usable_lints.sort_by_key(|lint| lint.name.clone()); | ||
|
|
||
| std::fs::write( | ||
| "../src/lintlist/mod.rs", |
There was a problem hiding this comment.
After the fact review:
Shouldn't this also be done with the replace_region_in_file function and then only update the content in the ALL_LINTS array? When a PR adds a lint, this file needs to get updated like README.md, ... If the update is done with the replace_region_in_file function (like below), travis will fail if it's not updated. cc @phansch
|
☀️ Test successful - checks-travis, status-appveyor |
#4173