Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make let_unit lint suggestion auto applicable #4337

Merged
merged 2 commits into from
Aug 5, 2019

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Aug 5, 2019

changelog: Make let_unit lint suggestion auto applicable

@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 5, 2019
Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the other reviews! This LGTM, too. r=me once #4336 is merged.

@phansch
Copy link
Member

phansch commented Aug 5, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 5, 2019

📌 Commit 385f447 has been approved by phansch

@bors
Copy link
Collaborator

bors commented Aug 5, 2019

⌛ Testing commit 385f447 with merge a90b3ba...

bors added a commit that referenced this pull request Aug 5, 2019
 Make let_unit lint suggestion auto applicable

changelog: Make `let_unit` lint suggestion auto applicable
@bors
Copy link
Collaborator

bors commented Aug 5, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing a90b3ba to master...

@bors bors merged commit 385f447 into rust-lang:master Aug 5, 2019
@flip1995 flip1995 deleted the let_unit branch May 4, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants