Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submodules: Update clippy #63280

Merged
merged 1 commit into from
Aug 7, 2019
Merged

submodules: Update clippy #63280

merged 1 commit into from
Aug 7, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Aug 5, 2019 •
edited
Loading

r? @Manishearth
Fixes clippy toolstate in #63228 (comment)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2019
@flip1995
Copy link
Member

flip1995 commented Aug 5, 2019

Would you mind bumping clippy again to the newest commit? I'd really like to have rust-lang/rust-clippy#4337 in the next nightly 😄

@tesuji
Copy link
Contributor Author

tesuji commented Aug 6, 2019

cc @oli-obk

@tesuji tesuji changed the title submodules: Update clippy [WIP] submodules: Update clippy Aug 6, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Aug 6, 2019 •
edited
Loading

Clippy broke again with #59369. Hence the PR description changed.

Edit: Block on rust-lang/rust-clippy#4340

@tesuji tesuji mentioned this pull request Aug 6, 2019
Merged
bors added a commit to rust-lang/rust-clippy that referenced this pull request Aug 7, 2019
@bors
Auto merge of #4340 - lzutao:rustup, r=oli-obk
b041511 
Rustup rust-lang/rust#59369

Unblock rust-lang/rust#63280

changelog: none
@tesuji tesuji changed the title [WIP] submodules: Update clippy submodules: Update clippy Aug 7, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Aug 7, 2019

It is ready again. cc @Manishearth

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 7, 2019

📌 Commit 070eb0c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2019
@bors
Copy link
Contributor

bors commented Aug 7, 2019

⌛ Testing commit 070eb0c with merge 647ed20...

bors added a commit that referenced this pull request Aug 7, 2019
@bors
Auto merge of #63280 - lzutao:update-clippy, r=Mark-Simulacrum
647ed20 
submodules: Update clippy

r? @Manishearth
Fixes clippy toolstate in #63228 (comment)
@bors
Copy link
Contributor

bors commented Aug 7, 2019

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 647ed20 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 7, 2019
@bors bors merged commit 070eb0c into rust-lang:master Aug 7, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #63280!

Tested on commit 647ed20.
Direct link to PR: #63280

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 7, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#63280!
da8face 
Tested on commit rust-lang/rust@647ed20.
Direct link to PR: <rust-lang/rust#63280>

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
@tesuji tesuji deleted the update-clippy branch August 7, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tesuji @rust-highfive @flip1995 @Mark-Simulacrum @bors @Manishearth